netdev - RE: [PATCH][net-next] net/smc: avoid atomic_set and smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3816364405a04427999739f5ca0b0536@baidu.com>
Date: Thu, 16 Nov 2023 12:06:21 +0000
From: "Li,Rongqing" <lirongqing@...du.com>
To: Wen Gu <guwen@...ux.alibaba.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-s390@...r.kernel.org"
	<linux-s390@...r.kernel.org>, "dust.li@...ux.alibaba.com"
	<dust.li@...ux.alibaba.com>
Subject: RE: [PATCH][net-next] net/smc: avoid atomic_set and smp_wmb in the tx
 path when possible



> -----Original Message-----
> From: Wen Gu <guwen@...ux.alibaba.com>
> Sent: Thursday, November 16, 2023 5:28 PM
> To: Li,Rongqing <lirongqing@...du.com>; wenjia@...ux.ibm.co;
> netdev@...r.kernel.org; linux-s390@...r.kernel.org; dust.li@...ux.alibaba.com
> Subject: Re: [PATCH][net-next] net/smc: avoid atomic_set and smp_wmb in the
> tx path when possible
> 
> 
> 
> On 2023/11/16 10:20, Li RongQing wrote:
> > there is rare possibility that conn->tx_pushing is not 1, since
>    There
> > tx_pushing is just checked with 1, so move the setting tx_pushing to 1
> > after atomic_dec_and_test() return false, to avoid atomic_set and
> > smp_wmb in tx path
>                          .
> >
> 
> Some nits:
> 
> 1. It is normally using [PATCH net-next] rather than [PATCH][net-next]
>     in subject. And new version should better be marked. such as:
> 
>     # git format-patch --subject-prefix="PATCH net-next" -v 3
> 
>     And CC all relevant people listed by:
> 
>     # ./scripts/get_maintainer.pl <your patch>
> 
> 2. Few improvements in the commit body.
> 
> 

Ok, thanks 

-Li