[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231116175724.GF109951@vergenet.net>
Date: Thu, 16 Nov 2023 17:57:24 +0000
From: Simon Horman <horms@...nel.org>
To: Justin Lai <justinlai0215@...ltek.com>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
pabeni@...hat.com, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, andrew@...n.ch, pkshih@...ltek.com,
larry.chiu@...ltek.com
Subject: Re: [PATCH net-next v11 00/13] Add Realtek automotive PCIe driver
On Wed, Nov 15, 2023 at 09:34:01PM +0800, Justin Lai wrote:
> This series includes adding realtek automotive ethernet driver
> and adding rtase ethernet driver entry in MAINTAINERS file.
>
> This ethernet device driver for the PCIe interface of
> Realtek Automotive Ethernet Switch,applicable to
> RTL9054, RTL9068, RTL9072, RTL9075, RTL9068, RTL9071.
...
> MAINTAINERS | 7 +
> drivers/net/ethernet/realtek/Kconfig | 17 +
> drivers/net/ethernet/realtek/Makefile | 1 +
> drivers/net/ethernet/realtek/rtase/Makefile | 10 +
> drivers/net/ethernet/realtek/rtase/rtase.h | 353 +++
> .../net/ethernet/realtek/rtase/rtase_main.c | 2542 +++++++++++++++++
> drivers/net/ethernet/realtek/rtase/tt.c | 2542 +++++++++++++++++
> drivers/net/ethernet/realtek/rtase/tt.h | 353 +++
Hi Justin,
Unless I am mistaken, by the end of this patch set tt.c is identical to
rtase_main.c, and tt.h is identical to rtase.h.
If so, why?
$ cd drivers/net/ethernet/realtek/rtase
$ sha1sum *.[ch] | sort
9762c7f0fc1acb214d1705905495fad6b902a3c8 rtase.h
9762c7f0fc1acb214d1705905495fad6b902a3c8 tt.h
ccfe889f5ae3b6ecfa0dfba91d30fd7beffd4291 rtase_main.c
ccfe889f5ae3b6ecfa0dfba91d30fd7beffd4291 tt.c
Powered by blists - more mailing lists