netdev - Re: [PATCH bpf-next v4 1/2] bpf: add skcipher API support to TC/XDP programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4d76f14-5045-4935-b699-e84beb645652@linux.dev>
Date: Fri, 17 Nov 2023 09:10:59 -0500
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Herbert Xu <herbert@...dor.apana.org.au>,
 Martin KaFai Lau <martin.lau@...ux.dev>
Cc: kuba@...nel.org, andrii@...nel.org, ast@...nel.org, mykolal@...com,
 bpf@...r.kernel.org, netdev@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH bpf-next v4 1/2] bpf: add skcipher API support to TC/XDP
 programs

On 16/11/2023 19:59, Herbert Xu wrote:
> Vadim Fedorenko <vadfed@...a.com> wrote:
>> Add crypto API support to BPF to be able to decrypt or encrypt packets
>> in TC/XDP BPF programs. Only symmetric key ciphers are supported for
>> now. Special care should be taken for initialization part of crypto algo
>> because crypto_alloc_sync_skcipher() doesn't work with preemtion
>> disabled, it can be run only in sleepable BPF program. Also async crypto
>> is not supported because of the very same issue - TC/XDP BPF programs
>> are not sleepable.
>>
>> Signed-off-by: Vadim Fedorenko <vadfed@...a.com>
> 
> Please use the newly introduced lskcipher interface instead of
> skcipher.

Oh, sounds like we do have proper API to work with buffers directly!
Thanks for pointing to it, I'll send v5 soon.