netdev - Re: [PATCH net-next 06/14] devlink: Add device lock assert in reload operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231117155138.GI164483@vergenet.net>
Date: Fri, 17 Nov 2023 15:51:38 +0000
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com,
	Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next 06/14] devlink: Add device lock assert in reload
 operation

On Wed, Nov 15, 2023 at 01:17:15PM +0100, Petr Machata wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> Add an assert to verify that the device lock is always held throughout
> reload operations.
> 
> Tested the following flows with netdevsim and mlxsw while lockdep is
> enabled:
> 
> netdevsim:
> 
>  # echo "10 1" > /sys/bus/netdevsim/new_device
>  # devlink dev reload netdevsim/netdevsim10
>  # ip netns add bla
>  # devlink dev reload netdevsim/netdevsim10 netns bla
>  # ip netns del bla
>  # echo 10 > /sys/bus/netdevsim/del_device
> 
> mlxsw:
> 
>  # devlink dev reload pci/0000:01:00.0
>  # ip netns add bla
>  # devlink dev reload pci/0000:01:00.0 netns bla
>  # ip netns del bla
>  # echo 1 > /sys/bus/pci/devices/0000\:01\:00.0/remove
>  # echo 1 > /sys/bus/pci/rescan
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>