netdev - Re: [PATCH net-next 12/14] mlxsw: pci: Add support for new reset flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231117155339.GM164483@vergenet.net>
Date: Fri, 17 Nov 2023 15:53:39 +0000
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Amit Cohen <amcohen@...dia.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 12/14] mlxsw: pci: Add support for new reset flow

On Wed, Nov 15, 2023 at 01:17:21PM +0100, Petr Machata wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> The driver resets the device during probe and during a devlink reload.
> The current reset method reloads the current firmware version or a
> pending one, if one was previously flashed using devlink. However, the
> current reset method does not result in a PCI hot reset, preventing the
> PCI firmware from being upgraded, unless the system is rebooted.
> 
> To solve this problem, a new reset command (6) was implemented in the
> firmware. Unlike the current command (1), after issuing the new command
> the device will not start the reset immediately, but only after a PCI
> hot reset.
> 
> Implement the new reset method by first verifying that it is supported
> by the current firmware version by querying the Management Capabilities
> Mask (MCAM) register. If supported, issue the new reset command (6) via
> MRSR register followed by a PCI reset by calling
> __pci_reset_function_locked().
> 
> Once the PCI firmware is operational, go back to the regular reset flow
> and wait for the entire device to become ready. That is, repeatedly read
> the "system_status" register from the BAR until a value of "FW_READY"
> (0x5E) appears.
> 
> Tested:
> 
>  # for i in $(seq 1 10); do devlink dev reload pci/0000:01:00.0; done
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>