[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1722479.1700252425@warthog.procyon.org.uk>
Date: Fri, 17 Nov 2023 20:20:25 +0000
From: David Howells <dhowells@...hat.com>
To: Jeff Layton <jlayton@...nel.org>
Cc: dhowells@...hat.com, Steve French <smfrench@...il.com>,
Matthew Wilcox <willy@...radead.org>,
Marc Dionne <marc.dionne@...istor.com>,
Paulo Alcantara <pc@...guebit.com>,
Shyam Prasad N <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>,
Dominique Martinet <asmadeus@...ewreck.org>,
Ilya Dryomov <idryomov@...il.com>,
Christian Brauner <christian@...uner.io>,
linux-afs@...ts.infradead.org, linux-cifs@...r.kernel.org,
linux-nfs@...r.kernel.org, ceph-devel@...r.kernel.org,
v9fs@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
linux-mm@...ck.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-cachefs@...hat.com
Subject: Re: [RFC PATCH 11/53] netfs: Add support for DIO buffering
Jeff Layton <jlayton@...nel.org> wrote:
> > + struct bio_vec *direct_bv; /* DIO buffer list (when handling iovec-iter) */
> > void *netfs_priv; /* Private data for the netfs */
> > + unsigned int direct_bv_count; /* Number of elements in bv[] */
>
> nit: "number of elements in direct_bv[]"
>
> Also, just for better readability, can you swap direct_bv and
> netfs_priv? Then at least the array and count are together.
Yeah - and stick a __counted_by() on too.
David
Powered by blists - more mailing lists