netdev - Re: [PATCH net] kselftest: rtnetlink: fix ip route command typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZVa+z0yqUzb5Wgt7@Laptop-X1>
Date: Fri, 17 Nov 2023 09:15:59 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Shuah Khan <shuah@...nel.org>,
	Daniel Mendes <dmendes@...hat.com>
Subject: Re: [PATCH net] kselftest: rtnetlink: fix ip route command typo

On Thu, Nov 16, 2023 at 06:01:41PM +0100, Paolo Abeni wrote:
> The blamed commit below introduced a typo causing 'gretap' test-case
> failures:
> 
> ./rtnetlink.sh  -t kci_test_gretap -v
> COMMAND: ip link add name test-dummy0 type dummy
> COMMAND: ip link set test-dummy0 up
> COMMAND: ip netns add testns
> COMMAND: ip link help gretap 2>&1 | grep -q '^Usage:'
> COMMAND: ip -netns testns link add dev gretap00 type gretap seq key 102 local 172.16.1.100 remote 172.16.1.200
> COMMAND: ip -netns testns addr add dev gretap00 10.1.1.100/24
> COMMAND: ip -netns testns link set dev gretap00 ups
>     Error: either "dev" is duplicate, or "ups" is a garbage.
> COMMAND: ip -netns testns link del gretap00
> COMMAND: ip -netns testns link add dev gretap00 type gretap external
> COMMAND: ip -netns testns link del gretap00
> FAIL: gretap
> 
> Fix it by using the correct keyword.
> 
> Fixes: 9c2a19f71515 ("kselftest: rtnetlink.sh: add verbose flag")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
>  tools/testing/selftests/net/rtnetlink.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
> index 5f2b3f6c0d74..38be9706c45f 100755
> --- a/tools/testing/selftests/net/rtnetlink.sh
> +++ b/tools/testing/selftests/net/rtnetlink.sh
> @@ -859,7 +859,7 @@ kci_test_gretap()
>  
>  
>  	run_cmd ip -netns "$testns" addr add dev "$DEV_NS" 10.1.1.100/24
> -	run_cmd ip -netns "$testns" link set dev $DEV_NS ups
> +	run_cmd ip -netns "$testns" link set dev $DEV_NS up
>  	run_cmd ip -netns "$testns" link del "$DEV_NS"
>  
>  	# test external mode
> -- 
> 2.41.0
> 

Reviewed-by: Hangbin Liu <liuhangbin@...il.com>