| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Nov 2023 23:04:57 -0800 From: Jinliang Wang <jinliangw@...gle.com> To: Jeremy Kerr <jk@...econstruct.com.au>, Matt Johnston <matt@...econstruct.com.au> Cc: William Kennington <wak@...gle.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Jinliang Wang <jinliangw@...gle.com> Subject: [PATCH] mctp-i2c: increase the MCTP_I2C_TX_WORK_LEN to 500 The original value (100) is not sufficient for our use case. For example, we have 4 NVMe-mi devices on the same i2c bus. When sending namespace create Admin command concurrently, they will send 4x4KB data to device concurrently, which may be split into 4x(4KB/64B)=256 packets. Tested: Before the fix, we will see below message in kernel log when concurrently sending namespace create commands to the 4 NVMe-MI devices on the same i2c bus: kernel: i2c i2c-6 mctpi2c6: BUG! Tx Ring full when queue awake! After the fix, the error message is gone. Signed-off-by: Jinliang Wang <jinliangw@...gle.com> --- drivers/net/mctp/mctp-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mctp/mctp-i2c.c b/drivers/net/mctp/mctp-i2c.c index b37a9e4bade4..b658aa040620 100644 --- a/drivers/net/mctp/mctp-i2c.c +++ b/drivers/net/mctp/mctp-i2c.c @@ -34,7 +34,7 @@ #define MCTP_I2C_BUFSZ (3 + MCTP_I2C_MAXBLOCK + 1) #define MCTP_I2C_MINLEN 8 #define MCTP_I2C_COMMANDCODE 0x0f -#define MCTP_I2C_TX_WORK_LEN 100 +#define MCTP_I2C_TX_WORK_LEN 500 /* Sufficient for 64kB at min mtu */ #define MCTP_I2C_TX_QUEUE_LEN 1100 -- 2.43.0.rc0.421.g78406f8d94-goog
Powered by blists - more mailing lists