netdev - Re: [PATCH] can: j1939: prevent deadlock by changing j1939_socks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231117081002.GA590719@pengutronix.de>
Date: Fri, 17 Nov 2023 09:10:02 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Ziqi Zhao <astrajoan@...oo.com>
Cc: ivan.orlov0322@...il.com, edumazet@...gle.com,
	syzbot+881d65229ca4f9ae8c84@...kaller.appspotmail.com,
	socketcan@...tkopp.net, bridge@...ts.linux-foundation.org,
	nikolay@...dia.com,
	syzbot+1591462f226d9cbf0564@...kaller.appspotmail.com,
	roopa@...dia.com, kuba@...nel.org, pabeni@...hat.com, arnd@...db.de,
	syzkaller-bugs@...glegroups.com, mudongliangabcd@...il.com,
	linux-can@...r.kernel.org, mkl@...gutronix.de,
	skhan@...uxfoundation.org, robin@...tonic.nl,
	linux-kernel@...r.kernel.org, linux@...pel-privat.de,
	kernel@...gutronix.de, netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] can: j1939: prevent deadlock by changing
 j1939_socks_lock to rwlock

On Mon, Aug 07, 2023 at 06:46:34AM +0200, Oleksij Rempel wrote:
> On Fri, Jul 21, 2023 at 09:22:26AM -0700, Ziqi Zhao wrote:
> > The following 3 locks would race against each other, causing the
> > deadlock situation in the Syzbot bug report:
> > 
> > - j1939_socks_lock
> > - active_session_list_lock
> > - sk_session_queue_lock
> > 
> > A reasonable fix is to change j1939_socks_lock to an rwlock, since in
> > the rare situations where a write lock is required for the linked list
> > that j1939_socks_lock is protecting, the code does not attempt to
> > acquire any more locks. This would break the circular lock dependency,
> > where, for example, the current thread already locks j1939_socks_lock
> > and attempts to acquire sk_session_queue_lock, and at the same time,
> > another thread attempts to acquire j1939_socks_lock while holding
> > sk_session_queue_lock.
> > 
> > NOTE: This patch along does not fix the unregister_netdevice bug
> > reported by Syzbot; instead, it solves a deadlock situation to prepare
> > for one or more further patches to actually fix the Syzbot bug, which
> > appears to be a reference counting problem within the j1939 codebase.
> > 
> > Reported-by: syzbot+1591462f226d9cbf0564@...kaller.appspotmail.com
> > Signed-off-by: Ziqi Zhao <astrajoan@...oo.com>

Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |