netdev - Re: [PATCH bpf v3 0/8] bpf_redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b187e42-5cfb-4004-9c96-3caac42749b2@linux.dev>
Date: Fri, 17 Nov 2023 16:00:13 -0800
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: Daniel Borkmann <daniel@...earbox.net>
Cc: kuba@...nel.org, razor@...ckwall.org, sdf@...gle.com, horms@...nel.org,
 netdev@...r.kernel.org, bpf@...r.kernel.org, martin.lau@...nel.org
Subject: Re: [PATCH bpf v3 0/8] bpf_redirect_peer fixes

On 11/13/23 4:42 PM, Daniel Borkmann wrote:
> This fixes bpf_redirect_peer stats accounting for veth and netkit,
> and adds tstats in the first place for the latter. Utilise indirect
> call wrapper for bpf_redirect_peer, and improve test coverage of the
> latter also for netkit devices. Details in the patches, thanks!
> 
> The series was targeted at bpf originally, and is done here as well,
> so it can trigger BPF CI. Jakub, if you think directly going via net
> is better since the majority of the diff touches net anyway, that is
> fine, too.
> 
> Thanks!
> 
> v2 -> v3:
>    - Add kdoc for pcpu_stat_type (Simon)
>    - Reject invalid type value in netdev_do_alloc_pcpu_stats (Simon)
>    - Add Reviewed-by tags from list
> v1 -> v2:
>    - Move stats allocation/freeing into net core (Jakub)
>    - As prepwork for the above, move vrf's dstats over into the core
>    - Add a check into stats alloc to enforce tstats upon
>      implementing ndo_get_peer_dev
>    - Add Acked-by tags from list

Acked-by: Martin KaFai Lau <martin.lau@...nel.org>

Considering folks may still be traveling after LPC, will give it an extra 
weekend before landing.