lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ffdd3f62-de0b-449b-ac2c-1ed9e9e3070e@kernel.org> Date: Sat, 18 Nov 2023 12:06:40 +0200 From: Roger Quadros <rogerq@...nel.org> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: Siddharth Vadapalli <s-vadapalli@...com>, Ravi Gunasekaran <r-gunasekaran@...com>, Kumar Kartikeya Dwivedi <memxor@...il.com>, Stanislav Fomichev <sdf@...gle.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Rob Herring <robh@...nel.org>, Marek Majtyka <alardam@...il.com>, Yunsheng Lin <linyunsheng@...wei.com>, linux-omap@...r.kernel.org, netdev@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH 5/7] net: ethernet: ti: cpsw: Convert to platform remove callback returning void On 17/11/2023 11:17, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Reviewed-by: Roger Quadros <rogerq@...nel.org>
Powered by blists - more mailing lists