lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <2332a2e2-740f-49a6-8bef-d90ed010a434@lunn.ch> Date: Sat, 18 Nov 2023 18:47:50 +0100 From: Andrew Lunn <andrew@...n.ch> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> Cc: Kory Maincent <kory.maincent@...tlin.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Luis Chamberlain <mcgrof@...nel.org>, Russ Weight <russ.weight@...ux.dev>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH net-next 8/9] dt-bindings: net: pse-pd: Add bindings for PD692x0 PSE controller > > + ports-matrix: > > + description: Port conversion matrix configuration > > I do not see such property defined anywhere. Your description should > explain what the purpose is and what it is exactly. Currently you just > repeat property name, so quite pointless. I have to agree. You appear to have a device which can supply power to 48 RJ-45 connectors on the front panel? Which probably maps to 48 ports of a Ethernet switch. How do i use these properties described here to say that eth42 connects to port 42 of the PSE? > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > > + minItems: 1 > > + maxItems: 48 > > + items: > > + items: > > + - description: Logical port number > > + minimum: 0 > > + maximum: 47 > > + - description: Physical port number A (0xff for undefined) > > + oneOf: > > + - minimum: 0 > > + maximum: 95 > > + - const: 0xff > > + - description: Physical port number B (0xff for undefined) It would be good to explain what Port A and B are. It might be obvious to somebody who knows PSE, but i have no idea... Andrew
Powered by blists - more mailing lists