netdev - Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 18 Nov 2023 16:22:14 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Luo Jie <quic_luoj@...cinc.com>
Cc: <andrew@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <robh+dt@...nel.org>,
 <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
 <hkallweit1@...il.com>, <linux@...linux.org.uk>, <corbet@....net>,
 <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v5 4/6] net: phy: at803x: add the function
 phydev_id_is_qca808x

On Sat, 18 Nov 2023 14:27:52 +0800 Luo Jie wrote:
> +static inline bool phydev_id_is_qca808x(struct phy_device *phydev)

Please drop the "inline" keyword. The compiler will decide what's best.