netdev - Re: [PATCH net-next v11 05/13] net:ethernet:realtek:rtase: Implement hardware configuration function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231118145046.7bb8efca@kernel.org>
Date: Sat, 18 Nov 2023 14:50:46 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Justin Lai <justinlai0215@...ltek.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <andrew@...n.ch>,
 <pkshih@...ltek.com>, <larry.chiu@...ltek.com>
Subject: Re: [PATCH net-next v11 05/13] net:ethernet:realtek:rtase:
 Implement hardware configuration function

On Wed, 15 Nov 2023 21:34:06 +0800 Justin Lai wrote:
> +	.ndo_vlan_rx_add_vid = rtase_vlan_rx_add_vid,
> +	.ndo_vlan_rx_kill_vid = rtase_vlan_rx_kill_vid,
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +	.ndo_poll_controller = rtase_netpoll,
> +#endif
> +	.ndo_setup_tc = rtase_setup_tc,

This patch is still way too huge. Please remove more functionality 
from the initial version of the driver. You certainly don't need VLAN
support or CBS offload to pass packets.