[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231119164254.GD186930@vergenet.net>
Date: Sun, 19 Nov 2023 16:42:54 +0000
From: Simon Horman <horms@...nel.org>
To: Raju Rangoju <Raju.Rangoju@....com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, Shyam-sundar.S-k@....com,
Sudheesh Mavila <sudheesh.mavila@....com>
Subject: Re: [PATCH v2 net-next 2/4] amd-xgbe: add support for Crater
ethernet device
On Thu, Nov 16, 2023 at 07:24:14PM +0530, Raju Rangoju wrote:
> Add the necessary support to enable Crater ethernet device. Since the
> BAR1 address cannot be used to access the XPCS registers on Crater, use
> the pci_{read/write}_config_dword calls.
>
> Co-developed-by: Sudheesh Mavila <sudheesh.mavila@....com>
> Signed-off-by: Sudheesh Mavila <sudheesh.mavila@....com>
> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>
...
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
...
> @@ -479,6 +492,22 @@ static int __maybe_unused xgbe_pci_resume(struct device *dev)
> return ret;
> }
>
> +static struct xgbe_version_data xgbe_v3 = {
> + .init_function_ptrs_phy_impl = xgbe_init_function_ptrs_phy_v2,
> + .xpcs_access = XGBE_XPCS_ACCESS_V3,
> + .mmc_64bit = 1,
> + .tx_max_fifo_size = 65536,
> + .rx_max_fifo_size = 65536,
> + .tx_tstamp_workaround = 1,
> + .ecc_support = 1,
> + .i2c_support = 1,
> + .irq_reissue_support = 1,
> + .tx_desc_prefetch = 5,
> + .rx_desc_prefetch = 5,
> + .an_cdr_workaround = 0,
> + .enable_rrc = 0,
> +};
Hi Raju and Sudheesh,
W=1 allmodconfig builds on x86_64 with gcc-13 and clang-16 flag that
xgbe_v3 us defined but not used.
Please take care to arrange patch-sets so that each patch builds
without introducing new warnings.
> +
> static struct xgbe_version_data xgbe_v2a = {
> .init_function_ptrs_phy_impl = xgbe_init_function_ptrs_phy_v2,
> .xpcs_access = XGBE_XPCS_ACCESS_V2,
...
Powered by blists - more mailing lists