netdev - Re: [PATCH bpf-next v5 2/2] selftests: bpf: crypto skcipher algo selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee9e6afb-479e-d38f-9424-5c79feded44d@linux.dev>
Date: Sun, 19 Nov 2023 23:52:51 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>,
 Vadim Fedorenko <vadfed@...a.com>
Cc: Jakub Kicinski <kuba@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Andrii Nakryiko <andrii@...nel.org>,
 Alexei Starovoitov <ast@...nel.org>, Mykola Lysenko <mykolal@...com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 Network Development <netdev@...r.kernel.org>,
 Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
 bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v5 2/2] selftests: bpf: crypto skcipher algo
 selftests

On 19.11.2023 21:58, Alexei Starovoitov wrote:
> On Sat, Nov 18, 2023 at 2:55 PM Vadim Fedorenko <vadfed@...a.com> wrote:
>>
>> +
>> +SEC("fentry.s/bpf_fentry_test1")
>> +int BPF_PROG(skb_crypto_setup)
>> +{
>> +       struct bpf_crypto_lskcipher_ctx *cctx;
>> +       struct bpf_dynptr key = {};
>> +       int err = 0;
>> +
>> +       status = 0;
>> +
>> +       bpf_dynptr_from_mem(crypto_key, sizeof(crypto_key), 0, &key);
>> +       cctx = bpf_crypto_lskcipher_ctx_create(crypto_algo, &key, &err);
> 
> Direct string will work here, right?
> What's the reason to use global var?

Mmm, yeah, should work. I'll update the test, thanks!