netdev - Re: [RFC] usbnet: assign unique random MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6fd275d5-6f98-4c93-a37d-e7169f8789dd@suse.com>
Date: Mon, 20 Nov 2023 11:44:43 +0100
From: Oliver Neukum <oneukum@...e.com>
To: Benjamin Poirier <benjamin.poirier@...il.com>,
 Oliver Neukum <oneukum@...e.com>
Cc: bjorn@...k.no, netdev@...r.kernel.org
Subject: Re: [RFC] usbnet: assign unique random MAC

On 16.11.23 21:48, Benjamin Poirier wrote:

> Before initialization, dev_addr is null (00:00:00:00:00:00). Since this
> patch moves the fallback address initialization after the
> 	if (info->bind) {
> block, if the bind() did not initialize the address, this patch changes
> the result of the
> 		     (net->dev_addr [0] & 0x02) == 0))
> test within the block, no? The test now takes place on an uninitialized
> address and the result goes from false to true.

Hi,

right this issue exists. V2 will come up.

	Regards
		Oliver