netdev - Re: [PATCH net-next 5/6] selftests: tc-testing: timeout on unbounded loops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231120173555.GE245676@kernel.org>
Date: Mon, 20 Nov 2023 17:35:55 +0000
From: Simon Horman <horms@...nel.org>
To: Pedro Tammela <pctammela@...atatu.com>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
	jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, shuah@...nel.org,
	victor@...atatu.com
Subject: Re: [PATCH net-next 5/6] selftests: tc-testing: timeout on unbounded
 loops

On Fri, Nov 17, 2023 at 02:12:07PM -0300, Pedro Tammela wrote:
> In the spirit of failing early, timeout on unbounded loops that take
> longer than 20 ticks to complete. Such loops are to ensure that objects
> created are already visible so tests can proceed without any issues.
> 
> If a test setup takes more than 20 ticks to see an object, there's
> definetely something wrong.
> 
> Signed-off-by: Pedro Tammela <pctammela@...atatu.com>

Hi Pedro,

no need to respin because of this, but 'definitely' is misspelt above.

Moving on, I am very pleased to see these loops become bounded in time.
So the above nit notwithstanding,

Reviewed-by: Simon Horman <horms@...nel.org>

...