netdev - Re: [DKIM] Re: [devel-ipsec] [RFC ipsec-next v2 0/8] Add IP-TFS mode to xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 20 Nov 2023 21:02:38 +0100
From: Antony Antony <antony@...nome.org>
To: Antony Antony <antony@...nome.org>
Cc: Christian Hopps <chopps@...n.net>,
	Andrew Cagney <andrew.cagney@...il.com>, devel@...ux-ipsec.org,
	netdev@...r.kernel.org,
	Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [DKIM] Re: [devel-ipsec] [RFC ipsec-next v2 0/8] Add IP-TFS mode
 to xfrm

On Mon, Nov 20, 2023 at 09:00:45PM +0100, Antony Antony wrote:
> On Mon, Nov 20, 2023 at 01:39:50PM -0500, Christian Hopps via Devel wrote:
> > 
> > Andrew Cagney <andrew.cagney@...il.com> writes:
> > 
> > > > I did a multiple days peer review with Chris on this pachset. So my
> > > > concerns are already addressed.
> > > > 
> > > > Further reviews are welcome! This is a bigger change and it would
> > > > be nice if more people could look at it.
> > > 
> > > I have a usability question.  What name should appear when a user
> > > interacts with and sees log messages from this feature?
> > >     ip-tfs, IP-TFS, IP_TFS
> > > or:
> > >    iptfs, IPTFS, ...
> > 
> > I think no `-` or `_` in the code/api. For documentation it is probably better to hew closer to the RFC and use `IP-TFS`.
> 
> That sounds good. However,
> iproute2 output, ip xfrm state, or "ip xfrm policy" is that documentation or code?
> 
> current unsubmitted patch shows: "iptfs"
> 
> src 192.1.2.23 dst 192.1.2.45
> 	proto esp spi 0x76ee6b87(1995336583) reqid 16389(0x00004005) mode iptfs

there also the following line further down in ip x s

iptfs-opts pkt-size 0 max-queue-size 1048576 drop-time 1000000 reorder-window 3 init-delay 0

> 
> root@...t:/testing/pluto/ikev2-74-iptfs-01 (iptfs-aa-20231120)# ip  x p
> src 192.0.1.0/24 dst 192.0.2.0/24
> 	dir out priority 1757393 ptype main
> 	tmpl src 192.1.2.45 dst 192.1.2.23
> 		proto esp reqid 16389 mode iptfs
> 
> -antony