netdev - Re: [PATCH iproute2 v2] ip, link: Add support for netkit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40a74dfd-e7cf-46fc-9c79-517ce2d6c51b@kernel.org>
Date: Mon, 20 Nov 2023 13:40:42 -0800
From: David Ahern <dsahern@...nel.org>
To: Stephen Hemminger <stephen@...workplumber.org>,
 Daniel Borkmann <daniel@...earbox.net>
Cc: razor@...ckwall.org, martin.lau@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v2] ip, link: Add support for netkit

On 11/20/23 1:30 PM, Stephen Hemminger wrote:
> On Mon, 20 Nov 2023 22:10:54 +0100
> Daniel Borkmann <daniel@...earbox.net> wrote:
> 
>> +static void netkit_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
>> +{
>> +	if (!tb)
>> +		return;
>> +	if (tb[IFLA_NETKIT_MODE]) {
>> +		__u32 mode = rta_getattr_u32(tb[IFLA_NETKIT_MODE]);
>> +
>> +		print_string(PRINT_ANY, "mode", "mode %s ",
>> +			     netkit_mode_strings[mode]);
> 
> What if kernel adds a new mode in future?
> Probably want something like:
> 
> 		print_string(PRINT_ANY, "mode", "mode %s ",
> 			mode >= ARRAY_SIZE(netkit_mode_strings) ? "UNKNOWN" : netkit_mode_strings[mode]);

that is why I asked for a table driven helper. Helper handles the mode
>= ARRAY_SIZE.