lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Nov 2023 08:02:35 +0200 From: claudiu beznea <claudiu.beznea@...on.dev> To: Sergey Shtylyov <s.shtylyov@....ru>, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, p.zabel@...gutronix.de, yoshihiro.shimoda.uh@...esas.com, geert+renesas@...der.be, wsa+renesas@...g-engineering.com, biju.das.jz@...renesas.com, prabhakar.mahadev-lad.rj@...renesas.com, sergei.shtylyov@...entembedded.com, mitsuhiro.kimura.kc@...esas.com, masaru.nagai.vx@...esas.com Cc: netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, Claudiu Beznea <claudiu.beznea.uj@...renesas.com> Subject: Re: [PATCH 03/13] net: ravb: Make write access to CXR35 first before accessing other EMAC registers On 20.11.2023 21:44, Sergey Shtylyov wrote: > On 11/20/23 11:45 AM, Claudiu wrote: > >> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com> >> >> Hardware manual of RZ/G3S (and RZ/G2L) specifies the following on the >> description of CXR35 register (chapter "PHY interface select register >> (CXR35)"): "After release reset, make write-access to this register before >> making write-access to other registers (except MDIOMOD). Even if not need >> to change the value of this register, make write-access to this register >> at least one time. Because RGMII/MII MODE is recognized by accessing this >> register". >> >> The setup procedure for EMAC module (chapter "Setup procedure" of RZ/G3S, >> RZ/G2L manuals) specifies the E-MAC.CXR35 register is the first EMAC >> register that is to be configured. >> >> Note [A] from chapter "PHY interface select register (CXR35)" specifies >> the following: >> [A] The case which CXR35 SEL_XMII is used for the selection of RGMII/MII >> in APB Clock 100 MHz. >> (1) To use RGMII interface, Set ‘H’03E8_0000’ to this register. >> (2) To use MII interface, Set ‘H’03E8_0002’ to this register. >> >> Take into account these indication. >> >> Fixes: 1089877ada8d ("ravb: Add RZ/G2L MII interface support") > > The bug fixes should be submitted separately and against the net.git repo... OK, thanks for pointing it. > >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com> > > Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru> > > [...] > > MBR, Sergey
Powered by blists - more mailing lists