netdev - Re: [PATCH] dt-bindings: net: renesas,ethertsn: Add bindings for Ethernet TSN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8005f686-c4e5-487d-8bcc-4f057ee059aa@linaro.org>
Date: Tue, 21 Nov 2023 13:53:47 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Cc: Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 devicetree@...r.kernel.org, netdev@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: net: renesas,ethertsn: Add bindings for
 Ethernet TSN

On 21/11/2023 13:44, Niklas Söderlund wrote:
>>
>>>
>>> I looked at the generic properties {rx,tx}-internal-delay-ps but they 
>>> are of int type. So I opted for a vendor specific bool property. Do you 
>>> think a better route is to use the generic property and force the value 
>>> to be either 0 or the typical delay?
>>>
>>>> Why this is property of a board (not SoC)?
>>>
>>> I'm sorry I don't understand this question.
>>
>> Why setting internal delay is specific to a board, not to a SoC? Why
>> each board would need to configure it? On which parts of hardware on the
>> board does this depend?
> 
> Ahh, I think I understand. It is per board as I understand the 
> documentation. It depends on the electrical characteristics of the 
> board.
> 
> Maybe updating the description would help, how about?
> 
>     Enable internal Rx clock delay. Typically 1.8ns but depends on 
>     electrical characteristics of the board.

Yes, this looks fine.

Best regards,
Krzysztof