netdev - Re: [PATCH v10 0/2] can: esd: add support for esd GmbH PCIe/402 CAN interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZ6RqJiCk_yc_V_1=TkJ41KjTQpDU--Z-kEwdUugoxMbz3G0A@mail.gmail.com>
Date: Wed, 22 Nov 2023 00:04:45 +0900
From: Vincent Mailhol <vincent.mailhol@...il.com>
To: Stefan Mätje <stefan.maetje@....eu>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>, linux-can@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Wolfgang Grandegger <wg@...ndegger.com>, 
	"David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v10 0/2] can: esd: add support for esd GmbH PCIe/402 CAN interface

On Tue. 21 Nov. 2023 at 02:57, Stefan Mätje <stefan.maetje@....eu> wrote:
> The purpose of this patch is to introduce a new CAN driver to support
> the esd GmbH 402 family of CAN interface boards. The hardware design
> is based on a CAN controller implemented in a FPGA attached to a
> PCIe link.
>
> More information on these boards can be found following the links
> included in the commit message.
>
> This patch supports all boards but will operate the CAN-FD capable
> boards only in Classic-CAN mode. The CAN-FD support will be added
> when the initial patch has stabilized.
>
> The patch is reuses the previous work of my former colleague:
> Link: https://lore.kernel.org/linux-can/1426592308-23817-1-git-send-email-thomas.koerper@esd.eu/
>
>
> The patch is based on the linux-can-next main branch.

I left one nitpick in patch 1 and two nitpicks in patch 2. Regardless,
for the full series:

Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>