lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Nov 2023 01:57:24 +0100 From: Andrew Lunn <andrew@...n.ch> To: Maxime Chevallier <maxime.chevallier@...tlin.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>, linux-arm-kernel@...ts.infradead.org, Christophe Leroy <christophe.leroy@...roup.eu>, Herve Codina <herve.codina@...tlin.com>, Florian Fainelli <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>, Köry Maincent <kory.maincent@...tlin.com>, Jesse Brandeburg <jesse.brandeburg@...el.com> Subject: Re: [RFC PATCH net-next v2 03/10] net: phy: add helpers to handle sfp phy connect/disconnect > +/** > + * phy_sfp_connect_phy - Connect the SFP module's PHY to the upstream PHY > + * @upstream: pointer to the upstream phy device > + * @phy: pointer to the SFP module's phy device > + * > + * This helper allows keeping track of PHY devices on the link. It adds the > + * SFP module's phy to the phy namespace of the upstream phy > + */ > +int phy_sfp_connect_phy(void *upstream, struct phy_device *phy) > +{ > + struct phy_device *phydev = upstream; Will this function only ever be called from a PHY driver? If so, we know upstream is PHY. So we can avoid using void * and make it a struct phy_device *. Andrew
Powered by blists - more mailing lists