lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Nov 2023 02:51:09 +0000 From: Yahui Cao <yahui.cao@...el.com> To: intel-wired-lan@...ts.osuosl.org Cc: kvm@...r.kernel.org, netdev@...r.kernel.org, lingyu.liu@...el.com, kevin.tian@...el.com, madhu.chittim@...el.com, sridhar.samudrala@...el.com, alex.williamson@...hat.com, jgg@...dia.com, yishaih@...dia.com, shameerali.kolothum.thodi@...wei.com, brett.creeley@....com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com Subject: [PATCH iwl-next v4 10/12] ice: Add device suspend function for migration From: Lingyu Liu <lingyu.liu@...el.com> Device suspend handler is called by vfio driver before saving device state. Typical operation includes stopping TX/RX queue. Signed-off-by: Lingyu Liu <lingyu.liu@...el.com> Signed-off-by: Yahui Cao <yahui.cao@...el.com> --- .../net/ethernet/intel/ice/ice_migration.c | 69 +++++++++++++++++++ include/linux/net/intel/ice_migration.h | 6 ++ 2 files changed, 75 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_migration.c b/drivers/net/ethernet/intel/ice/ice_migration.c index 082ae2b79f60..a11cd0d3ad3d 100644 --- a/drivers/net/ethernet/intel/ice/ice_migration.c +++ b/drivers/net/ethernet/intel/ice/ice_migration.c @@ -2,6 +2,8 @@ /* Copyright (C) 2018-2023 Intel Corporation */ #include "ice.h" +#include "ice_lib.h" +#include "ice_fltr.h" #include "ice_base.h" #include "ice_txrx_lib.h" @@ -274,6 +276,73 @@ u32 ice_migration_supported_caps(void) return VIRTCHNL_VF_MIGRATION_SUPPORT_FEATURE; } +/** + * ice_migration_suspend_dev - suspend device + * @pf: pointer to PF of migration device + * @vf_id: VF index of migration device + * + * Return 0 for success, negative for error + */ +int ice_migration_suspend_dev(struct ice_pf *pf, int vf_id) +{ + struct device *dev = ice_pf_to_dev(pf); + struct ice_vsi *vsi; + struct ice_vf *vf; + int ret; + + vf = ice_get_vf_by_id(pf, vf_id); + if (!vf) { + dev_err(dev, "Unable to locate VF from VF ID%d\n", vf_id); + return -EINVAL; + } + + if (!test_bit(ICE_VF_STATE_QS_ENA, vf->vf_states)) { + ret = 0; + goto out_put_vf; + } + + if (vf->virtchnl_msg_num > VIRTCHNL_MSG_MAX) { + dev_err(dev, "SR-IOV live migration disabled on VF %d. Migration buffer exceeded\n", + vf->vf_id); + ret = -EIO; + goto out_put_vf; + } + + vsi = ice_get_vf_vsi(vf); + if (!vsi) { + dev_err(dev, "VF %d VSI is NULL\n", vf->vf_id); + ret = -EINVAL; + goto out_put_vf; + } + + /* Prevent VSI from queuing incoming packets by removing all filters */ + ice_fltr_remove_all(vsi); + + /* MAC based filter rule is disabled at this point. Set MAC to zero + * to keep consistency with VF mac address info shown by ip link + */ + eth_zero_addr(vf->hw_lan_addr); + eth_zero_addr(vf->dev_lan_addr); + + ret = ice_vsi_stop_lan_tx_rings(vsi, ICE_NO_RESET, vf->vf_id); + if (ret) { + dev_err(dev, "VF %d failed to stop tx rings\n", vf->vf_id); + ret = -EIO; + goto out_put_vf; + } + ret = ice_vsi_stop_all_rx_rings(vsi); + if (ret) { + dev_err(dev, "VF %d failed to stop rx rings\n", vf->vf_id); + ret = -EIO; + goto out_put_vf; + } + +out_put_vf: + ice_put_vf(vf); + return ret; +} +EXPORT_SYMBOL(ice_migration_suspend_dev); + /** * ice_migration_save_rx_head - save rx head into device state buffer * @vf: pointer to VF structure diff --git a/include/linux/net/intel/ice_migration.h b/include/linux/net/intel/ice_migration.h index a142b78283a8..47f46dca07ae 100644 --- a/include/linux/net/intel/ice_migration.h +++ b/include/linux/net/intel/ice_migration.h @@ -14,6 +14,7 @@ int ice_migration_save_devstate(struct ice_pf *pf, int vf_id, u8 *buf, u64 buf_sz); int ice_migration_load_devstate(struct ice_pf *pf, int vf_id, const u8 *buf, u64 buf_sz); +int ice_migration_suspend_dev(struct ice_pf *pf, int vf_id); #else static inline struct ice_pf *ice_migration_get_pf(struct pci_dev *pdev) { @@ -37,6 +38,11 @@ static inline int ice_migration_load_devstate(struct ice_pf *pf, int vf_id, { return 0; } + +static inline int ice_migration_suspend_dev(struct ice_pf *pf, int vf_id) +{ + return 0; +} #endif /* CONFIG_ICE_VFIO_PCI */ #endif /* _ICE_MIGRATION_H_ */ -- 2.34.1
Powered by blists - more mailing lists