[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231122092939.1005591-1-yinjun.zhang@corigine.com>
Date: Wed, 22 Nov 2023 17:29:39 +0800
From: Yinjun Zhang <yinjun.zhang@...igine.com>
To: hengqi@...ux.alibaba.com
Cc: ast@...nel.org,
davem@...emloft.net,
edumazet@...gle.com,
hawk@...nel.org,
horms@...nel.org,
jasowang@...hat.com,
john.fastabend@...il.com,
kuba@...nel.org,
mst@...hat.com,
netdev@...r.kernel.org,
pabeni@...hat.com,
virtualization@...ts.linux-foundation.org,
xuanzhuo@...ux.alibaba.com
Subject: Re: [PATCH net-next v4 4/4] virtio-net: support rx netdim
On Mon, 20 Nov 2023 20:37:34 +0800, Heng Qi wrote:
<...>
> @@ -2179,6 +2220,7 @@ static void virtnet_disable_queue_pair(struct virtnet_info *vi, int qp_index)
> virtnet_napi_tx_disable(&vi->sq[qp_index].napi);
> napi_disable(&vi->rq[qp_index].napi);
> xdp_rxq_info_unreg(&vi->rq[qp_index].xdp_rxq);
> + cancel_work_sync(&vi->rq[qp_index].dim.work);
I'm not sure, but please check if here may cause deadlock:
rtnl_lock held ->
.ndo_stop ->
virtnet_disable_queue_pair() ->
cancel_work_sync() ->
virtnet_rx_dim_work() ->
rtnl_lock()
> }
>
> static int virtnet_enable_queue_pair(struct virtnet_info *vi, int qp_index)
<...>
Powered by blists - more mailing lists