[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d26eae8d-4968-4ab0-bd9b-696d7b3865ec@linaro.org>
Date: Wed, 22 Nov 2023 11:12:40 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Kathiravan Thirumoorthy <quic_kathirav@...cinc.com>,
Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Michael Turquette <mturquette@...libre.com>, Stephen Boyd
<sboyd@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Richard Cochran <richardcochran@...il.com>,
Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 3/9] dt-bindings: clock: ipq5332: drop the few nss
clocks definition
On 22/11/2023 11:08, Kathiravan Thirumoorthy wrote:
>
>
> On 11/21/2023 8:36 PM, Krzysztof Kozlowski wrote:
>> On 21/11/2023 15:30, Kathiravan Thirumoorthy wrote:
>>> In commit 0dd3f263c810 ("clk: qcom: ipq5332: enable few nssnoc clocks in
>>
>> Where is this commit coming from?
>>
>>> driver probe"), gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk,
>>> gcc_nssnoc_nsscc_clk are enabled in driver probe to keep it always-on.
>>
>> Implementation can change and for example bring back these clocks. Are
>> you going to change bindings? No, drop the patch.
>>
>> Bindings should be dropped only in a few rare cases like clocks not
>> available for OS or bugs.
>
> Thanks Krzysztof. Will drop this patch in V3.
>
> One more question to understand further. In IPQ SoCs there are bunch of
> coresight / QDSS clocks but coresight framework doesn't handle all
> clocks. Those clocks are enabled in bootloader stage itself. In such
> case, should I drop the clocks from both binding and driver or only from
> driver?
That's not really the reason to drop them at all. Neither from driver,
nor from bindings. You should not rely on bootloader handling your clocks
Best regards,
Krzysztof
Powered by blists - more mailing lists