netdev - Re: [PATCH net 1/3] amd-xgbe: handle corner-case during sfp hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f92839a-6cef-4707-a0cb-68312ae4e6d1@intel.com>
Date: Wed, 22 Nov 2023 11:31:18 +0100
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: Raju Rangoju <Raju.Rangoju@....com>, <netdev@...r.kernel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <Thomas.Lendacky@....com>, <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH net 1/3] amd-xgbe: handle corner-case during sfp hotplug



On 21.11.2023 20:14, Raju Rangoju wrote:
> Force the mode change for SFI in Fixed PHY configurations. Fixed PHY
> configurations needs PLL to be enabled while doing mode set. When the
> SFP module isn't connected during boot, driver assumes AN is ON and
> attempts auto-negotiation. However, if the connected SFP comes up in
> Fixed PHY configuration the link will not come up as PLL isn't enabled
> while the initial mode set command is issued. So, force the mode change
> for SFI in Fixed PHY configuration to fix link issues.
> 
> Fixes: e57f7a3feaef ("amd-xgbe: Prepare for working with more than one type of phy")
> Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>
> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>
> ---

Thanks for our patches!
Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>

>  drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> index 32d2c6fac652..4a2dc705b528 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> @@ -1193,7 +1193,19 @@ static int xgbe_phy_config_fixed(struct xgbe_prv_data *pdata)
>  	if (pdata->phy.duplex != DUPLEX_FULL)
>  		return -EINVAL;
>  
> -	xgbe_set_mode(pdata, mode);
> +	/* Force the mode change for SFI in Fixed PHY config.
> +	 * Fixed PHY configs needs PLL to be enabled while doing mode set.
> +	 * When the SFP module isn't connected during boot, driver assumes
> +	 * AN is ON and attempts autonegotiation. However, if the connected
> +	 * SFP comes up in Fixed PHY config, the link will not come up as
> +	 * PLL isn't enabled while the initial mode set command is issued.
> +	 * So, force the mode change for SFI in Fixed PHY configuration to
> +	 * fix link issues.
> +	 */
> +	if (mode == XGBE_MODE_SFI)
> +		xgbe_change_mode(pdata, mode);
> +	else
> +		xgbe_set_mode(pdata, mode);
>  
>  	return 0;
>  }