netdev - [PATCH v2 1/4] i915: make inject_virtual

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231122-vfs-eventfd-signal-v2-1-bd549b14ce0c@kernel.org>
Date: Wed, 22 Nov 2023 13:48:22 +0100
From: Christian Brauner <brauner@...nel.org>
To: linux-fsdevel@...r.kernel.org
Cc: Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.cz>, 
 Vitaly Kuznetsov <vkuznets@...hat.com>, 
 Sean Christopherson <seanjc@...gle.com>, 
 Paolo Bonzini <pbonzini@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, 
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
 Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
 David Woodhouse <dwmw2@...radead.org>, Paul Durrant <paul@....org>, 
 Oded Gabbay <ogabbay@...nel.org>, Wu Hao <hao.wu@...el.com>, 
 Tom Rix <trix@...hat.com>, Moritz Fischer <mdf@...nel.org>, 
 Xu Yilun <yilun.xu@...el.com>, Zhenyu Wang <zhenyuw@...ux.intel.com>, 
 Zhi Wang <zhi.a.wang@...el.com>, Jani Nikula <jani.nikula@...ux.intel.com>, 
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, 
 Rodrigo Vivi <rodrigo.vivi@...el.com>, 
 Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>, 
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
 Leon Romanovsky <leon@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>, 
 Frederic Barrat <fbarrat@...ux.ibm.com>, 
 Andrew Donnellan <ajd@...ux.ibm.com>, Arnd Bergmann <arnd@...db.de>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Eric Farman <farman@...ux.ibm.com>, Matthew Rosato <mjrosato@...ux.ibm.com>, 
 Halil Pasic <pasic@...ux.ibm.com>, Vineeth Vijayan <vneethv@...ux.ibm.com>, 
 Peter Oberparleiter <oberpar@...ux.ibm.com>, 
 Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, 
 Alexander Gordeev <agordeev@...ux.ibm.com>, 
 Christian Borntraeger <borntraeger@...ux.ibm.com>, 
 Sven Schnelle <svens@...ux.ibm.com>, Tony Krowiak <akrowiak@...ux.ibm.com>, 
 Jason Herne <jjherne@...ux.ibm.com>, 
 Harald Freudenberger <freude@...ux.ibm.com>, 
 "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>, 
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, 
 Diana Craciun <diana.craciun@....nxp.com>, 
 Alex Williamson <alex.williamson@...hat.com>, 
 Eric Auger <eric.auger@...hat.com>, Fei Li <fei1.li@...el.com>, 
 Benjamin LaHaise <bcrl@...ck.org>, Christian Brauner <brauner@...nel.org>, 
 Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...nel.org>, 
 Roman Gushchin <roman.gushchin@...ux.dev>, 
 Shakeel Butt <shakeelb@...gle.com>, Muchun Song <muchun.song@...ux.dev>, 
 Kirti Wankhede <kwankhede@...dia.com>, kvm@...r.kernel.org, 
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
 linux-fpga@...r.kernel.org, intel-gvt-dev@...ts.freedesktop.org, 
 intel-gfx@...ts.freedesktop.org, linux-rdma@...r.kernel.org, 
 linuxppc-dev@...ts.ozlabs.org, linux-s390@...r.kernel.org, 
 linux-usb@...r.kernel.org, virtualization@...ts.linux-foundation.org, 
 netdev@...r.kernel.org, linux-aio@...ck.org, cgroups@...r.kernel.org, 
 linux-mm@...ck.org, Jens Axboe <axboe@...nel.dk>, 
 Pavel Begunkov <asml.silence@...il.com>, io-uring@...r.kernel.org
Subject: [PATCH v2 1/4] i915: make inject_virtual_interrupt() void

The single caller of inject_virtual_interrupt() ignores the return value
anyway. This allows us to simplify eventfd_signal() in follow-up
patches.

Signed-off-by: Christian Brauner <brauner@...nel.org>
---
 drivers/gpu/drm/i915/gvt/interrupt.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c b/drivers/gpu/drm/i915/gvt/interrupt.c
index de3f5903d1a7..9665876b4b13 100644
--- a/drivers/gpu/drm/i915/gvt/interrupt.c
+++ b/drivers/gpu/drm/i915/gvt/interrupt.c
@@ -422,7 +422,7 @@ static void init_irq_map(struct intel_gvt_irq *irq)
 #define MSI_CAP_DATA(offset) (offset + 8)
 #define MSI_CAP_EN 0x1

-static int inject_virtual_interrupt(struct intel_vgpu *vgpu)
+static void inject_virtual_interrupt(struct intel_vgpu *vgpu)
 {
 	unsigned long offset = vgpu->gvt->device_info.msi_cap_offset;
 	u16 control, data;
@@ -434,10 +434,10 @@ static int inject_virtual_interrupt(struct intel_vgpu *vgpu)

 	/* Do not generate MSI if MSIEN is disabled */
 	if (!(control & MSI_CAP_EN))
-		return 0;
+		return;

 	if (WARN(control & GENMASK(15, 1), "only support one MSI format\n"))
-		return -EINVAL;
+		return;

 	trace_inject_msi(vgpu->id, addr, data);

@@ -451,10 +451,10 @@ static int inject_virtual_interrupt(struct intel_vgpu *vgpu)
 	 * returned and don't inject interrupt into guest.
 	 */
 	if (!test_bit(INTEL_VGPU_STATUS_ATTACHED, vgpu->status))
-		return -ESRCH;
-	if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger, 1) != 1)
-		return -EFAULT;
-	return 0;
+		return;
+	if (!vgpu->msi_trigger)
+		return;
+	eventfd_signal(vgpu->msi_trigger, 1);
 }

 static void propagate_event(struct intel_gvt_irq *irq,

-- 
2.42.0