netdev - Re: [PATCH net-next] net: phylink: require supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df267967-74ed-4d8a-a86c-8e7b23897356@kernel.org>
Date: Wed, 22 Nov 2023 23:10:01 +1000
From: Greg Ungerer <gerg@...nel.org>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phylink: require supported_interfaces to be
 filled

On 22/11/23 19:27, Russell King (Oracle) wrote:
> On Wed, Nov 22, 2023 at 02:12:44PM +1000, Greg Ungerer wrote:
>> So I am thinking that something like this actually makes more sense now:
>>
>> --- a/drivers/net/dsa/mv88e6xxx/chip.c
>> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
>> @@ -577,6 +577,18 @@ static void mv88e6250_phylink_get_caps(struct mv88e6xxx_chip *chip, int port,
>>          config->mac_capabilities = MAC_SYM_PAUSE | MAC_10 | MAC_100;
>>   }
>> +static void mv88e6350_phylink_get_caps(struct mv88e6xxx_chip *chip, int port,
>> +                                      struct phylink_config *config)
>> +{
>> +       unsigned long *supported = config->supported_interfaces;
>> +
>> +       /* Translate the default cmode */
>> +       mv88e6xxx_translate_cmode(chip->ports[port].cmode, supported);
>> +
>> +       config->mac_capabilities = MAC_SYM_PAUSE | MAC_10 | MAC_100 |
>> +                                  MAC_1000FD;
>> +}
>> +
> 
> Looks sensible to me - but I do notice that a black line has been lost
> between mv88e6250_phylink_get_caps() and your new function - probably
> down to your email client being stupid with whitespace because it's
> broken the patch context. Just be aware of that when you come to send
> the patch for real.

Oh, yes, for sure. The above was a cut and paste into email client.
I'll send proper patches via git send-email soon.

Regards
Greg