netdev - Re: [PATCH net-next v3 03/13] net: page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40025e46-c631-40e7-a3e4-49c77bdb141f@kernel.org>
Date: Wed, 22 Nov 2023 15:20:23 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 almasrymina@...gle.com, ilias.apalodimas@...aro.org, dsahern@...il.com,
 dtatulea@...dia.com, willemb@...gle.com
Subject: Re: [PATCH net-next v3 03/13] net: page_pool: record pools per netdev



On 11/22/23 04:44, Jakub Kicinski wrote:
> Link the page pools with netdevs. This needs to be netns compatible
> so we have two options. Either we record the pools per netns and
> have to worry about moving them as the netdev gets moved.
> Or we record them directly on the netdev so they move with the netdev
> without any extra work.
> 
> Implement the latter option. Since pools may outlast netdev we need
> a place to store orphans. In time honored tradition use loopback
> for this purpose.
> 
> Reviewed-by: Mina Almasry<almasrymina@...gle.com>
> Signed-off-by: Jakub Kicinski<kuba@...nel.org>
> ---
> v1: fix race between page pool and netdev disappearing (Simon)
> ---
>   include/linux/list.h          | 20 ++++++++
>   include/linux/netdevice.h     |  4 ++
>   include/linux/poison.h        |  2 +
>   include/net/page_pool/types.h |  4 ++
>   net/core/page_pool_user.c     | 90 +++++++++++++++++++++++++++++++++++
>   5 files changed, 120 insertions(+)

I like it :-)

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>