netdev - Re: [PATCH net-next v3 11/13] net: page_pool: expose page pool stats via netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb6b70cd-9f92-4f78-8337-65154188c0ab@kernel.org>
Date: Wed, 22 Nov 2023 16:51:03 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 almasrymina@...gle.com, ilias.apalodimas@...aro.org, dsahern@...il.com,
 dtatulea@...dia.com, willemb@...gle.com,
 kernel-team <kernel-team@...udflare.com>
Subject: Re: [PATCH net-next v3 11/13] net: page_pool: expose page pool stats
 via netlink



On 11/22/23 04:44, Jakub Kicinski wrote:
> Dump the stats into netlink. More clever approaches
> like dumping the stats per-CPU for each CPU individually
> to see where the packets get consumed can be implemented
> in the future.
> 
> A trimmed example from a real (but recently booted system):
> 
> $ ./cli.py --no-schema --spec netlink/specs/netdev.yaml \
>             --dump page-pool-stats-get
> [{'info': {'id': 19, 'ifindex': 2},
>    'alloc-empty': 48,
>    'alloc-fast': 3024,
>    'alloc-refill': 0,
>    'alloc-slow': 48,
>    'alloc-slow-high-order': 0,
>    'alloc-waive': 0,
>    'recycle-cache-full': 0,
>    'recycle-cached': 0,
>    'recycle-released-refcnt': 0,
>    'recycle-ring': 0,
>    'recycle-ring-full': 0},
>   {'info': {'id': 18, 'ifindex': 2},
>    'alloc-empty': 66,
>    'alloc-fast': 11811,
>    'alloc-refill': 35,
>    'alloc-slow': 66,
>    'alloc-slow-high-order': 0,
>    'alloc-waive': 0,
>    'recycle-cache-full': 1145,
>    'recycle-cached': 6541,
>    'recycle-released-refcnt': 0,
>    'recycle-ring': 1275,
>    'recycle-ring-full': 0},
>   {'info': {'id': 17, 'ifindex': 2},
>    'alloc-empty': 73,
>    'alloc-fast': 62099,
>    'alloc-refill': 413,
> ...
> 
> Signed-off-by: Jakub Kicinski<kuba@...nel.org>
> ---
>   Documentation/netlink/specs/netdev.yaml |  78 ++++++++++++++++++
>   Documentation/networking/page_pool.rst  |  10 ++-
>   include/net/page_pool/helpers.h         |   8 +-
>   include/uapi/linux/netdev.h             |  19 +++++
>   net/core/netdev-genl-gen.c              |  32 ++++++++
>   net/core/netdev-genl-gen.h              |   7 ++
>   net/core/page_pool.c                    |   2 +-
>   net/core/page_pool_user.c               | 103 ++++++++++++++++++++++++
>   8 files changed, 250 insertions(+), 9 deletions(-)

Great to get stats support.

Looking forward to get feedback from my new colleagues at Cloudflare
how to consume this into our monitoring systems :-)

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>