netdev - Re: [PATCH v2 2/4] eventfd: simplify eventfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 22 Nov 2023 17:19:06 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Christian Brauner <brauner@...nel.org>, linux-fsdevel@...r.kernel.org
Cc: Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.cz>, Vitaly
 Kuznetsov <vkuznets@...hat.com>, Sean Christopherson <seanjc@...gle.com>,
 Paolo Bonzini <pbonzini@...hat.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave
 Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, David Woodhouse
 <dwmw2@...radead.org>, Paul Durrant <paul@....org>, Oded Gabbay
 <ogabbay@...nel.org>, Wu Hao <hao.wu@...el.com>, Tom Rix
 <trix@...hat.com>, Moritz Fischer <mdf@...nel.org>, Xu Yilun
 <yilun.xu@...el.com>, Zhenyu Wang <zhenyuw@...ux.intel.com>, Zhi Wang
 <zhi.a.wang@...el.com>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>, Tvrtko Ursulin
 <tvrtko.ursulin@...ux.intel.com>, David Airlie <airlied@...il.com>, Daniel
 Vetter <daniel@...ll.ch>, Leon Romanovsky <leon@...nel.org>, Jason
 Gunthorpe <jgg@...pe.ca>, Frederic Barrat <fbarrat@...ux.ibm.com>, Andrew
 Donnellan <ajd@...ux.ibm.com>, Arnd Bergmann <arnd@...db.de>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Eric Farman
 <farman@...ux.ibm.com>, Matthew Rosato <mjrosato@...ux.ibm.com>, Halil
 Pasic <pasic@...ux.ibm.com>, Vineeth Vijayan <vneethv@...ux.ibm.com>,
 Peter Oberparleiter <oberpar@...ux.ibm.com>, Heiko Carstens
 <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
 <agordeev@...ux.ibm.com>, Christian Borntraeger
 <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Tony
 Krowiak <akrowiak@...ux.ibm.com>, Jason Herne <jjherne@...ux.ibm.com>,
 Harald Freudenberger <freude@...ux.ibm.com>, "Michael S. Tsirkin"
 <mst@...hat.com>, Jason Wang <jasowang@...hat.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, Diana Craciun <diana.craciun@....nxp.com>,
 Alex Williamson <alex.williamson@...hat.com>, Eric Auger
 <eric.auger@...hat.com>, Fei Li <fei1.li@...el.com>, Benjamin LaHaise
 <bcrl@...ck.org>, Christian Brauner <brauner@...nel.org>, Johannes Weiner
 <hannes@...xchg.org>, Michal Hocko <mhocko@...nel.org>, Roman Gushchin
 <roman.gushchin@...ux.dev>, Shakeel Butt <shakeelb@...gle.com>, Muchun
 Song <muchun.song@...ux.dev>, Kirti Wankhede <kwankhede@...dia.com>,
 kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-fpga@...r.kernel.org,
 intel-gvt-dev@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
 linux-rdma@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 linux-s390@...r.kernel.org, linux-usb@...r.kernel.org,
 virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
 linux-aio@...ck.org, cgroups@...r.kernel.org, linux-mm@...ck.org, Jens
 Axboe <axboe@...nel.dk>, Pavel Begunkov <asml.silence@...il.com>,
 io-uring@...r.kernel.org
Subject: Re: [PATCH v2 2/4] eventfd: simplify eventfd_signal()

On Wed, 22 Nov 2023, Christian Brauner <brauner@...nel.org> wrote:
> diff --git a/fs/eventfd.c b/fs/eventfd.c
> index 33a918f9566c..dc9e01053235 100644
> --- a/fs/eventfd.c
> +++ b/fs/eventfd.c
> @@ -74,20 +74,17 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask)
>  /**
>   * eventfd_signal - Adds @n to the eventfd counter.

This still refers to @n here, and in patch 4.

BR,
Jani.

>   * @ctx: [in] Pointer to the eventfd context.
> - * @n: [in] Value of the counter to be added to the eventfd internal counter.
> - *          The value cannot be negative.
>   *
>   * This function is supposed to be called by the kernel in paths that do not
>   * allow sleeping. In this function we allow the counter to reach the ULLONG_MAX
>   * value, and we signal this as overflow condition by returning a EPOLLERR
>   * to poll(2).
>   *
> - * Returns the amount by which the counter was incremented.  This will be less
> - * than @n if the counter has overflowed.
> + * Returns the amount by which the counter was incremented.
>   */
> -__u64 eventfd_signal(struct eventfd_ctx *ctx, __u64 n)
> +__u64 eventfd_signal(struct eventfd_ctx *ctx)
>  {
> -	return eventfd_signal_mask(ctx, n, 0);
> +	return eventfd_signal_mask(ctx, 1, 0);
>  }
>  EXPORT_SYMBOL_GPL(eventfd_signal);
>  

-- 
Jani Nikula, Intel