netdev - Re: [PATCH net-next v3 09/13] net: page_pool: report amount of memory held by page pools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 22 Nov 2023 17:09:53 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, almasrymina@...gle.com, ilias.apalodimas@...aro.org,
 dsahern@...il.com, dtatulea@...dia.com, willemb@...gle.com
Subject: Re: [PATCH net-next v3 09/13] net: page_pool: report amount of memory
 held by page pools



On 11/22/23 17:06, Jakub Kicinski wrote:
> On Wed, 22 Nov 2023 16:24:55 +0100 Jesper Dangaard Brouer wrote:
>>> +      -
>>> +        name: inflight
>>> +        type: uint
>>> +        doc: |
>>> +          Number of outstanding references to this page pool (allocated
>>> +          but yet to be freed pages).
>>
>> Maybe it is worth explaining in this doc that these inflight references
>> also cover elements in (ptr) ring (and alloc-cache) ?
>>
>> In a follow up patchset, we likely also want to expose the PP ring size.
>> As that could be relevant when assessing inflight number.
> 
> Good point, how about:
> 
>            Number of outstanding references to this page pool (allocated
>            but yet to be freed pages). Allocated pages may be held in
>            socket receive queues, driver receive rings, page pool recycling
>            ring, the page pool cache, etc.

Sound good to me :-) - ACK

--Jesper