netdev - Re: [PATCH net-next v3 07/13] net: page_pool: implement GET in the netlink API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 22 Nov 2023 17:21:32 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, almasrymina@...gle.com, ilias.apalodimas@...aro.org,
 dsahern@...il.com, dtatulea@...dia.com, willemb@...gle.com,
 kernel-team <kernel-team@...udflare.com>
Subject: Re: [PATCH net-next v3 07/13] net: page_pool: implement GET in the
 netlink API



On 11/22/23 17:00, Jakub Kicinski wrote:
> On Wed, 22 Nov 2023 15:39:48 +0100 Jesper Dangaard Brouer wrote:
>> Can we still somehow list "detached" page_pool's with ifindex==1
>> (LOOPBACK_IFINDEX) ?
> 
> Do you mean filter at the kernel level to dump just them? Or whether
> they are visible at all?
> 

I mean if they are visible.

> They are visible, with ifindex attribute absent.
> 

Okay, I thought they would be listed with ifindex==1, but good to know.

> If you mean filtering - I was considering various filters but it seems
> like in "production" use we dump all the page pools, anyway.
> The detached ones need to be kept in check, obviously, but the "live"
> ones also have to be monitored to make sure they don't eat up too much
> memory.
> 
> The code we prepared at Meta for when this gets merged logs:
>   - sum(inflight-mem), not detached
>   - sum(inflight-mem), detached
>   - recycling rate (similar calculation to the sample in the last patch)
> 
> It may be useful in CLI to dump all detached pools but ad-hoc CLI can
> just filter in user space, doesn't have to be super efficient.

I think it will be okay to let userspace filter these.

--Jesper