netdev - Re: [patch net-next v3 5/9] genetlink: implement release callback and free sk_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231122090820.3b139890@kernel.org>
Date: Wed, 22 Nov 2023 09:08:20 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net,
 edumazet@...gle.com, jacob.e.keller@...el.com, jhs@...atatu.com,
 johannes@...solutions.net, andriy.shevchenko@...ux.intel.com,
 amritha.nambiar@...el.com, sdf@...gle.com, horms@...nel.org
Subject: Re: [patch net-next v3 5/9] genetlink: implement release callback
 and free sk_user_data there

On Wed, 22 Nov 2023 10:29:44 +0100 Jiri Pirko wrote:
> >If you're doing it centrally, please put the state as a new field in
> >the netlink socket. sk_user_data is for the user.  
> 
> I planned to use sk_user_data. What do you mean it is for the user?
> I see it is already used for similar usecase by connector for example:

I'm pretty sure I complained when it was being added. Long story.
AFAIU user as in if the socket is opened by a kernel module, the kernel
module is the user. There's no need to use this field for the
implementation since the implementation can simply extend its 
own structure to add a properly typed field.