[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231122175750.GA6731@kernel.org>
Date: Wed, 22 Nov 2023 17:57:50 +0000
From: Simon Horman <horms@...nel.org>
To: Oliver Neukum <oneukum@...e.com>
Cc: bjorn@...k.no, andrew@...n.ch, netdev@...r.kernel.org
Subject: Re: [RFCv2] usbnet: assign unique random MAC
On Mon, Nov 20, 2023 at 12:44:27PM +0100, Oliver Neukum wrote:
> The old method had the bug of issuing the same
> random MAC over and over even to every device.
> This bug is as old as the driver.
>
> This new method generates each device whose minidriver
> does not provide its own MAC its own unique random
> MAC.
>
> Signed-off-by: Oliver Neukum <oneukum@...e.com>
Thanks Oliver,
I agree with the approach taken here - using a random address as a fallback
if the driver (hw) doesn't provide one. The patch looks clean to me.
And, form my reading, addresses feedback provided on earlier versions.
Reviewed-by: Simon Horman <horms@...nel.org>
When you repost as a non RFC please consider if this is a fix,
in which case it should have an appropriate Fixes tag. Or
as an enhancement (I lean towards this), in which case it should
be targeted at net-next.
The target tree should be included in the Subject, e.g.
Subject: [PATCH net-next] usbnet: assign unique random MAC
Link: https://docs.kernel.org/process/maintainer-netdev.html
Also, please expand the CC list as per the output of:
get_maintainer.pl <this.patch>
...
Powered by blists - more mailing lists