netdev - Re: [PATCH net 0/3] dpaa2-eth: various fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZV5OzJ70dW1WxeyQ@lzaremba-mobl.ger.corp.intel.com>
Date: Wed, 22 Nov 2023 19:56:12 +0100
From: Larysa Zaremba <larysa.zaremba@...el.com>
To: Ioana Ciornei <ioana.ciornei@....com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <andrew@...n.ch>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net 0/3] dpaa2-eth: various fixes

On Wed, Nov 22, 2023 at 05:51:14PM +0200, Ioana Ciornei wrote:
> The first two patches fix a memory corruption issue happening between
> the Tx and Tx confirmation of a packet by making the Tx alignment at
> 64bytes mandatory instead of optional as it was previously.
> 
> The third patch fixes the Rx copybreak code path which recycled the
> initial data buffer before all processing was done on the packet.
>

I think patches 1&2 should form a single patch, because they are supposed to be 
backported to older stable kernels and this is hard to do, if one of patches 
lacks "Fixes" tag. At the same time, they clearly complement each other.
 
> Ioana Ciornei (3):
>   dpaa2-eth: increase the needed headroom to account for alignment
>   dpaa2-eth: set needed_headroom for net_device
>   dpaa2-eth: recycle the RX buffer only after all processing done
> 
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 16 ++++++++++------
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h |  2 +-
>  2 files changed, 11 insertions(+), 7 deletions(-)
> 
> -- 
> 2.25.1
> 
>