netdev - Re: [PATCH net-next 08/10] net: wwan: qcom_bam_dmux: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a62e93f0-7d95-41ee-91c1-cbdd316f94d7@gmail.com>
Date: Thu, 23 Nov 2023 00:23:53 +0200
From: Sergey Ryazanov <ryazanov.s.a@...il.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Jakub Kicinski <kuba@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Loic Poulain <loic.poulain@...aro.org>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>
Cc: Andy Gross <agross@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Stephan Gerhold <stephan@...hold.net>,
 Johannes Berg <johannes@...solutions.net>, netdev@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net-next 08/10] net: wwan: qcom_bam_dmux: Convert to
 platform remove callback returning void

On 17.11.2023 11:59, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Sergey Ryazanov <ryazanov.s.a@...il.com>