lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 23 Nov 2023 00:23:53 +0200
From: Sergey Ryazanov <>
To: Uwe Kleine-König <>,
 Jakub Kicinski <>, Bjorn Andersson <>,
 Loic Poulain <>, "David S. Miller"
 <>, Eric Dumazet <>
Cc: Andy Gross <>, Paolo Abeni <>,
 Konrad Dybcio <>,
 Stephan Gerhold <>,
 Johannes Berg <>,,,
Subject: Re: [PATCH net-next 08/10] net: wwan: qcom_bam_dmux: Convert to
 platform remove callback returning void

On 17.11.2023 11:59, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> Signed-off-by: Uwe Kleine-König <>

Reviewed-by: Sergey Ryazanov <>

Powered by blists - more mailing lists