netdev - RE: [PATCH net] net: axienet: Fix check for partial TX checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 22 Nov 2023 03:00:20 +0000
From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
To: Samuel Holland <samuel.holland@...ive.com>
CC: Ariane Keller <ariane.keller@....ee.ethz.ch>, Daniel Borkmann
	<daniel@...earbox.net>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Simek, Michal"
	<michal.simek@....com>, Paolo Abeni <pabeni@...hat.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [PATCH net] net: axienet: Fix check for partial TX checksum

> -----Original Message-----
> From: Samuel Holland <samuel.holland@...ive.com>
> Sent: Wednesday, November 22, 2023 6:12 AM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@....com>
> Cc: Samuel Holland <samuel.holland@...ive.com>; Ariane Keller
> <ariane.keller@....ee.ethz.ch>; Daniel Borkmann <daniel@...earbox.net>;
> David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Simek, Michal
> <michal.simek@....com>; Paolo Abeni <pabeni@...hat.com>; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> netdev@...r.kernel.org
> Subject: [PATCH net] net: axienet: Fix check for partial TX checksum
> 
> Due to a typo, the code checked the RX checksum feature in the TX path.
> 
> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet
> driver")
> Signed-off-by: Samuel Holland <samuel.holland@...ive.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Thanks!
> ---
> 
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 82d0d44b2b02..bf6e33990490 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct
> net_device *ndev)
>  		if (lp->features & XAE_FEATURE_FULL_TX_CSUM) {
>  			/* Tx Full Checksum Offload Enabled */
>  			cur_p->app0 |= 2;
> -		} else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) {
> +		} else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) {
>  			csum_start_off = skb_transport_offset(skb);
>  			csum_index_off = csum_start_off + skb-
> >csum_offset;
>  			/* Tx Partial Checksum Offload Enabled */
> --
> 2.42.0