netdev - Re: [net-next PATCH v3 2/2] octeontx2-pf: TC flower offload support for mirror

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92d95955f66098ce725729243251beacc2823a81.camel@redhat.com>
Date: Thu, 23 Nov 2023 11:21:36 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Wojciech Drewek <wojciech.drewek@...el.com>, Suman Ghosh
 <sumang@...vell.com>, sgoutham@...vell.com, gakula@...vell.com, 
 sbhatta@...vell.com, hkelam@...vell.com, davem@...emloft.net,
 edumazet@...gle.com,  kuba@...nel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,  lcherian@...vell.com, jerinj@...vell.com,
 horms@...nel.org
Subject: Re: [net-next PATCH v3 2/2] octeontx2-pf: TC flower offload support
 for mirror

On Tue, 2023-11-21 at 15:48 +0100, Wojciech Drewek wrote:
> 
> On 21.11.2023 10:43, Suman Ghosh wrote:
> > This patch extends TC flower offload support for mirroring
> > ingress/egress traffic to a different PF/VF. Below is an example
> > command,
> > 
> > 'tc filter add dev eth1 ingress protocol ip flower src_ip <ip-addr>
> > skip_sw action mirred ingress mirror dev eth2'
> > 
> > Signed-off-by: Suman Ghosh <sumang@...vell.com>
> 
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>

Thank you for your review!

Please, additionally try to trim away the irrelevant part of the patch
when replying (in this case almost everything). That helps a lot
following the discussion, especially on long patches, thanks!

@Suman: please retain Wojciech's tag on next revision of this series.

Cheers,

Paolo