netdev - Re: [PATCH net-next v1 2/3] net: dsa: microchip: Remove redundant optimization in ksz8_w_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3735179804cb941bbdd17cbdee5efd9a25a72df.camel@redhat.com>
Date: Thu, 23 Nov 2023 11:54:57 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>, "David S. Miller"
 <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>, Eric Dumazet
 <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>, Jakub
 Kicinski <kuba@...nel.org>, Vladimir Oltean <olteanv@...il.com>, Woojung
 Huh <woojung.huh@...rochip.com>, Arun Ramadoss <arun.ramadoss@...rochip.com>
Cc: kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org,  UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next v1 2/3] net: dsa: microchip: Remove redundant
 optimization in ksz8_w_phy_bmcr

On Tue, 2023-11-21 at 16:24 +0100, Oleksij Rempel wrote:
> Remove the manual checks for register value changes in the
> ksz8_w_phy_bmcr function. Instead, rely on regmap_update_bits() for
> optimizing register updates.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>  drivers/net/dsa/microchip/ksz8795.c | 95 +++++++++--------------------
>  1 file changed, 28 insertions(+), 67 deletions(-)
> 
> diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c
> index 835157815937..4c1e21fd87da 100644
> --- a/drivers/net/dsa/microchip/ksz8795.c
> +++ b/drivers/net/dsa/microchip/ksz8795.c
> @@ -951,107 +951,68 @@ static int ksz8_w_phy_ctrl(struct ksz_device *dev, int port, u16 val)
>  static int ksz8_w_phy_bmcr(struct ksz_device *dev, int port, u16 val)
>  {
>  	const u16 *regs = dev->info->regs;
> -	u8 restart, ctrl, speed, data;
> +	u8 restart, speed, ctrl, restart_mask;

Very minor nit and only if you have to repost for some other reason,
please respect the reverse x-mas tree above.

Thanks,

Paolo