netdev - Re: [PATCH 2/2] net: dsa: mv88e6xxx: fix marvell 6350 probe crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d36c0e2-0d0d-4704-8d3b-2d902e29e664@lunn.ch>
Date: Thu, 23 Nov 2023 20:40:22 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Greg Ungerer <gerg@...nel.org>
Cc: rmk+kernel@...linux.org.uk, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH 2/2] net: dsa: mv88e6xxx: fix marvell 6350 probe crash

> @@ -3892,7 +3892,8 @@ static int mv88e6xxx_port_setup(struct dsa_switch *ds, int port)
>  	struct mv88e6xxx_chip *chip = ds->priv;
>  	int err;
>  
> -	if (chip->info->ops->pcs_ops->pcs_init) {
> +	if (chip->info->ops->pcs_ops &&
> +	    chip->info->ops->pcs_ops->pcs_init) {
>  		err = chip->info->ops->pcs_ops->pcs_init(chip, port);
>  		if (err)
>  			return err;

mv88e6xxx_port_teardown() seems to have the same problem. Could you
fix that as well?

Thanks

	Andrew