Message-ID: <cb41cf91-1c75-4edc-b00f-59763344b15c@kernel.dk>
Date: Thu, 23 Nov 2023 12:43:23 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Christian Brauner <brauner@...nel.org>, linux-fsdevel@...r.kernel.org
Cc: Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.cz>,
 Vitaly Kuznetsov <vkuznets@...hat.com>,
 Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini
 <pbonzini@...hat.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
 David Woodhouse <dwmw2@...radead.org>, Paul Durrant <paul@....org>,
 Oded Gabbay <ogabbay@...nel.org>, Wu Hao <hao.wu@...el.com>,
 Tom Rix <trix@...hat.com>, Moritz Fischer <mdf@...nel.org>,
 Xu Yilun <yilun.xu@...el.com>, Zhenyu Wang <zhenyuw@...ux.intel.com>,
 Zhi Wang <zhi.a.wang@...el.com>, Jani Nikula <jani.nikula@...ux.intel.com>,
 Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Leon Romanovsky <leon@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>,
 Frederic Barrat <fbarrat@...ux.ibm.com>, Andrew Donnellan
 <ajd@...ux.ibm.com>, Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Eric Farman <farman@...ux.ibm.com>, Matthew Rosato <mjrosato@...ux.ibm.com>,
 Halil Pasic <pasic@...ux.ibm.com>, Vineeth Vijayan <vneethv@...ux.ibm.com>,
 Peter Oberparleiter <oberpar@...ux.ibm.com>,
 Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
 Alexander Gordeev <agordeev@...ux.ibm.com>,
 Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>, Tony Krowiak <akrowiak@...ux.ibm.com>,
 Jason Herne <jjherne@...ux.ibm.com>,
 Harald Freudenberger <freude@...ux.ibm.com>,
 "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Diana Craciun <diana.craciun@....nxp.com>,
 Alex Williamson <alex.williamson@...hat.com>,
 Eric Auger <eric.auger@...hat.com>, Fei Li <fei1.li@...el.com>,
 Benjamin LaHaise <bcrl@...ck.org>, Johannes Weiner <hannes@...xchg.org>,
 Michal Hocko <mhocko@...nel.org>, Roman Gushchin <roman.gushchin@...ux.dev>,
 Shakeel Butt <shakeelb@...gle.com>, Muchun Song <muchun.song@...ux.dev>,
 Kirti Wankhede <kwankhede@...dia.com>, kvm@...r.kernel.org,
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-fpga@...r.kernel.org, intel-gvt-dev@...ts.freedesktop.org,
 intel-gfx@...ts.freedesktop.org, linux-rdma@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org, linux-s390@...r.kernel.org,
 linux-usb@...r.kernel.org, virtualization@...ts.linux-foundation.org,
 netdev@...r.kernel.org, linux-aio@...ck.org, cgroups@...r.kernel.org,
 linux-mm@...ck.org, Pavel Begunkov <asml.silence@...il.com>,
 io-uring@...r.kernel.org
Subject: Re: [PATCH v2 0/4] eventfd: simplify signal helpers

On 11/22/23 5:48 AM, Christian Brauner wrote:
> Hey everyone,
> 
> This simplifies the eventfd_signal() and eventfd_signal_mask() helpers
> significantly. They can be made void and not take any unnecessary
> arguments.
> 
> I've added a few more simplifications based on Sean's suggestion.
> 
> Signed-off-by: Christian Brauner <brauner@...nel.org>
> 
> Changes in v2:
> - further simplify helpers
> - Link to v1: https://lore.kernel.org/r/20230713-vfs-eventfd-signal-v1-0-7fda6c5d212b@kernel.org

Only oddity I spotted was the kerneldoc, which someone else already
brought up.

Reviewed-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe

Powered by blists - more mailing lists