[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f5438fff-9682-42d4-822d-4f4f7020e114@lunn.ch>
Date: Thu, 23 Nov 2023 21:02:04 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Suraj Jaiswal <quic_jsuraj@...cinc.com>
Cc: Vinod Koul <vkoul@...nel.org>,
Bhupesh Sharma <bhupesh.sharma@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
Prasad Sodagudi <psodagud@...cinc.com>,
Andrew Halaney <ahalaney@...hat.com>, kernel@...cinc.com
Subject: Re: [PATCH net-next v3 3/3] net: stmmac: Add driver support for
DWMAC5 fault IRQ Support
> @@ -702,6 +718,10 @@ int stmmac_get_platform_resources(struct platform_device *pdev,
> if (stmmac_res->irq < 0)
> return stmmac_res->irq;
>
> + ret = stmmac_get_fault_intr_config(pdev, stmmac_res);
> + if (ret)
> + dev_err(&pdev->dev, "Fault interrupt not present\n");
This fault/saftey/foobar interrupt is optional? So printing any error
message it is missing does not seem like a good idea.
Andrew
Powered by blists - more mailing lists