netdev - Re: [PATCH net-next] bonding: remove print in bond_verify_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 23 Nov 2023 10:13:27 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Zhengchao Shao <shaozhengchao@...wei.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, j.vosburgh@...il.com,
	andy@...yhouse.net, weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net-next] bonding: remove print in bond_verify_device_path

On Thu, Nov 23, 2023 at 09:55:15AM +0800, Zhengchao Shao wrote:
> As suggested by Paolo in link[1], if the memory allocation fails, the mm
> layer will emit a lot warning comprising the backtrace, so remove the
> print.
> 
> [1] https://lore.kernel.org/all/20231118081653.1481260-1-shaozhengchao@huawei.com/
> 
> Suggested-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
>  drivers/net/bonding/bond_main.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index d987432cee3b..4e0600c7b050 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2973,11 +2973,8 @@ struct bond_vlan_tag *bond_verify_device_path(struct net_device *start_dev,
>  
>  	if (start_dev == end_dev) {
>  		tags = kcalloc(level + 1, sizeof(*tags), GFP_ATOMIC);
> -		if (!tags) {
> -			net_err_ratelimited("%s: %s: Failed to allocate tags\n",
> -					    __func__, start_dev->name);
> +		if (!tags)
>  			return ERR_PTR(-ENOMEM);
> -		}
>  		tags[level].vlan_proto = BOND_VLAN_PROTO_NONE;
>  		return tags;
>  	}
> -- 
> 2.34.1
> 

Reviewed-by: Hangbin Liu <liuhangbin@...il.com>