lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231124110335.GM50352@kernel.org> Date: Fri, 24 Nov 2023 11:03:35 +0000 From: Simon Horman <horms@...nel.org> To: Jesse Brandeburg <jesse.brandeburg@...el.com> Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, Julia Lawall <Julia.Lawall@...ia.fr>, Marcin Szycik <marcin.szycik@...ux.intel.com> Subject: Re: [PATCH iwl-next v1 13/13] ice: field get conversion On Tue, Nov 21, 2023 at 01:19:21PM -0800, Jesse Brandeburg wrote: > Refactor the ice driver to use FIELD_GET() for mask and shift reads, > which reduces lines of code and adds clarity of intent. > > This code was generated by the following coccinelle/spatch script and > then manually repaired. > > @get@ > constant shift,mask; > type T; > expression a; > @@ > -(((T)(a) & mask) >> shift) > +FIELD_GET(mask, a) > > and applied via: > spatch --sp-file field_prep.cocci --in-place --dir \ > drivers/net/ethernet/intel/ > > Cc: Julia Lawall <Julia.Lawall@...ia.fr> > Reviewed-by: Marcin Szycik <marcin.szycik@...ux.intel.com> > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com> Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists