netdev - Re: [PATCHv2 1/2] net: dsa: mv88e6xxx: fix marvell 6350 switch probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2117b82b-d99e-4181-be80-cc2253c9eb95@lunn.ch>
Date: Fri, 24 Nov 2023 16:54:32 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Greg Ungerer <gerg@...nel.org>
Cc: rmk+kernel@...linux.org.uk, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org
Subject: Re: [PATCHv2 1/2] net: dsa: mv88e6xxx: fix marvell 6350 switch
 probing

On Fri, Nov 24, 2023 at 02:15:28PM +1000, Greg Ungerer wrote:
> As of commit de5c9bf40c45 ("net: phylink: require supported_interfaces to
> be filled") Marvell 88e6350 switches fail to be probed:
> 
>     ...
>     mv88e6085 d0072004.mdio-mii:11: switch 0x3710 detected: Marvell 88E6350, revision 2
>     mv88e6085 d0072004.mdio-mii:11: phylink: error: empty supported_interfaces
>     error creating PHYLINK: -22
>     mv88e6085: probe of d0072004.mdio-mii:11 failed with error -22
>     ...
> 
> The problem stems from the use of mv88e6185_phylink_get_caps() to get
> the device capabilities. Create a new dedicated phylink_get_caps for the
> 6351 family (which the 6350 is one of) to properly support their set of
> capabilities.
> 
> According to chip.h the 6351 switch family includes the 6171, 6175, 6350
> and 6351 switches, so update each of these to use the correct
> phylink_get_caps.
> 
> Fixes: de5c9bf40c45 ("net: phylink: require supported_interfaces to be filled")
> Signed-off-by: Greg Ungerer <gerg@...nel.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew