lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c9424992-98cd-c675-22dd-360b7392054b@omp.ru> Date: Fri, 24 Nov 2023 22:02:03 +0300 From: Sergey Shtylyov <s.shtylyov@....ru> To: claudiu beznea <claudiu.beznea@...on.dev>, <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>, <p.zabel@...gutronix.de>, <yoshihiro.shimoda.uh@...esas.com>, <geert+renesas@...der.be>, <wsa+renesas@...g-engineering.com>, <biju.das.jz@...renesas.com>, <prabhakar.mahadev-lad.rj@...renesas.com>, <sergei.shtylyov@...entembedded.com>, <mitsuhiro.kimura.kc@...esas.com>, <masaru.nagai.vx@...esas.com> CC: <netdev@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Claudiu Beznea <claudiu.beznea.uj@...renesas.com> Subject: Re: [PATCH 02/13] net: ravb: Use pm_runtime_resume_and_get() On 11/21/23 8:57 AM, claudiu beznea wrote: [...] >>> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com> >>> >>> pm_runtime_get_sync() may return with error. In case it returns with error >>> dev->power.usage_count needs to be decremented. pm_runtime_resume_and_get() >>> takes care of this. Thus use it. >>> >>> Along with this pm_runtime_resume_and_get() and reset_control_deassert() >>> were moved before alloc_etherdev_mqs() to simplify the error path. >> >> I don't see how it simplifies the error path... > > By not changing it... Actually, I took the other approach: you suggested in But it does need to be changed! It's not currently in the reverse order compared to the buildup path... > patch 1 to re-arrange the error path, I did it the other way around: > changed the initialization path... That way you needlessly obfuscate (by moving the code around) the core change you do in this patch: switching from calling pm_runtime_get_sync() to calling pm_runtime_resume_and_get(). :-/ [...] >>> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") >>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com> >> [...] MBR, Sergey
Powered by blists - more mailing lists