[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <rsj2usphrnghq3gnwkbho7rek7ffbgyur4kjuakpfxwu7zqpzw@cj3rmd4gupxq>
Date: Fri, 24 Nov 2023 13:59:24 -0700
From: Daniel Xu <dxu@...uu.xyz>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: John Fastabend <john.fastabend@...il.com>,
"David S. Miller" <davem@...emloft.net>, Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>,
Jakub Kicinski <kuba@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
Shuah Khan <shuah@...nel.org>, Steffen Klassert <steffen.klassert@...unet.com>,
antony.antony@...unet.com, Martin KaFai Lau <martin.lau@...ux.dev>,
Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>,
Jiri Olsa <jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>, bpf <bpf@...r.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
Network Development <netdev@...r.kernel.org>, devel@...ux-ipsec.org
Subject: Re: [PATCH ipsec-next v1 7/7] bpf: xfrm: Add selftest for
bpf_xdp_get_xfrm_state()
Hi Alexei,
On Wed, Nov 22, 2023 at 03:28:16PM -0800, Alexei Starovoitov wrote:
> On Wed, Nov 22, 2023 at 10:21 AM Daniel Xu <dxu@...uu.xyz> wrote:
> >
> > +
> > + bpf_printk("replay-window %d\n", x->replay_esn->replay_window);
>
> Pls no printk in tests. Find a different way to validate.
Ack. I'll migrate the ipsec tunnel tests to test_progs next rev so it
can use mmaped globals.
Thanks,
Daniel
Powered by blists - more mailing lists